Born in Paisley, Jock started his career with Pollock, a junior side. He was also a junior internationalist.
He signed for Dundee in 1921, making his debut away to Greenock Morton in a 2-1 defeat. He initially slotted into the defence. A versatile player he went on to play in most positions for the team.
Although a mainstay of the team, he only scored two goals with the club. Both came in February season 1921/22. The first against Kilmarnock in a 5-3 defeat and the second came three days later in a 2-0 home win against Dumbarton
When Dundee went on a tour of Spain in 1924 Jock was team captain.
He was presented to King Alfonso after Dundee had beaten Real Madrid 2-0 in front of a crowd of 22,500.
During the tour he wrote home to a friend:
“We fairly put the damper on Barcelona. It was a good laugh to see the Spaniards cannon off Davie McLean like billiard balls.” He went on to say “I was sorry I was not able to play in the second match owning to an injury to my thigh. However, the boys pulled through all right.”
The following season Dundee made it to the final of the Scottish Cup, their opponents were Celtic. Jock led the team out at Hampden as captain. Dundee dominated the first half, going ahead 1-0 in the 30th minute. It took Celtic until the 81st and 86th minute to score, ending Dundee’s hope for silverware.
He was given a benefit game in 1928, which took place on September 5th, versus St Johnstone. Blackburn Rovers and Sunderland had been approached as potential opponents, but both had to decline. Dundee won the match 3-1 in front of a “few hundred spectators.”
Jock was given a free transfer in May 1929. His last appearance was against Rangers, which ended in a 1-0 defeat away from home. Supporters were disappointed to hear that he was being released, as he was popular with the supporters who felt he still had plenty to give to the team. Rumours had circulated that he was going to sign for Liverpool, Dundee’s manager quickly refuted this. By June he had swapped allegiance to Dundee United, taking up a position in defence.
After a season at Tannadice Jock moved to Wales, joining Connah’s Quay. Shortly after arriving at the Flintshire club he was made captain.