Johnnie started his career with Vale of Leven, he recalled later in life that he “paid 3d to enter the ground as a spectator.” Just before the kick-off he accepted an invitation to play, and was rewarded after the game, “with a 2d pie and a bottle of lemonade.”
He signed for Dundee in 1894, and was a regular member of the team, missing only one match in season 1895-1896. After a dispute with the club directors, in 1896, Johnnie transferred to Bury F.C.
On April 21st, 1900, Bury won the F.A. cup, beating Southampton 4-0. For Johnnie this must have been the pinnacle of his career with the Shakers. He was rewarded by the club with a benefit match, after making 157 appearances.
After a short, successful spell, with Blackburn Rovers, Johnnie made the move back to Dundee, and Dens Park, in 1902 for a fee of £100. The Muir-Darroch-Sharp defence of that era gained recognition as one of the most formidable in Scotland.
By 1906, he made the decision to retire, age and injuries had crept up on him. After hanging up his boots”” he was employed as a pool attendant at Dundee Public Baths, where he stayed until his retirement.
Johnnie died on the 24th November, 1949. His funeral, at the Western Cemetery, was attended by former team mates James Dickson and John McHardy, and former club director William McIntosh.